Added Natural Key Serialization section to docs #790
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #790 +/- ##
=======================================
Coverage 83.44% 83.44%
=======================================
Files 26 26
Lines 1649 1649
Branches 264 264
=======================================
Hits 1376 1376
Misses 207 207
Partials 66 66 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
With the changes in #814 this documentation is no longer necessary. dumpdata managers will already be marked as non_polymorphic() so there is no special requirement to make your get_by_natural_key() calls non_polymorphic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Django's natural key serialization with :django-admin:
dumpdataand:django-admin:
loaddata, polymorphic models require special handling.polymorphic.managers.PolymorphicQuerySet.non_polymorphic in
get_by_natural_key()for polymorphic models. Without this, deserialization failswhen loading new objects because polymorphic queries try to fetch incomplete objects.
Closes #517